Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate qiskit.result.mitigation #13351

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Oct 22, 2024

Summary

Closes #12838

Details and comments

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11595253287

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 88.709%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.73%
Totals Coverage Status
Change from base Build 11592501902: 0.02%
Covered Lines: 75524
Relevant Lines: 85137

💛 - Coveralls

@ElePT ElePT changed the title Deprecate qiskit.result.deprecation Deprecate qiskit.result.mitigation Oct 22, 2024
@ElePT ElePT added this to the 1.3.0 milestone Oct 22, 2024
@ElePT ElePT marked this pull request as ready for review October 22, 2024 13:56
@ElePT ElePT requested a review from a team as a code owner October 22, 2024 13:56
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT added the Changelog: Deprecation Include in "Deprecated" section of changelog label Oct 22, 2024
@ElePT ElePT linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I had one question inline about the release note. But it's easy enough to fix in the release notes roundup as we approach the final release. Feel free to enqueue this for merge.

Comment on lines +4 to +5
The ``qiskit.result.mitigation`` module has been deprecated and will be removed in the 2.0 release.
The deprecation includes the ``LocalReadoutMitigator`` and ``CorrelatedReadoutMitigator`` classes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't want to use class refs for these? They seem to be in the docs: https://docs.quantum.ibm.com/api/qiskit/qiskit.result.LocalReadoutMitigator

Copy link
Contributor Author

@ElePT ElePT Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remember if we would use refs for removals, I will keep it in mind and suggest the changes in the reno copy-editing phase. This way we can get the merge queue going with this PR :)

removal_timeline="in Qiskit 2.0",
additional_msg="The `qiskit.result.mitigation` module is deprecated in favor of "
"the https://github.com/Qiskit/qiskit-addon-mthree package.",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only the 3 classes above are actually public so these technically could just be removed. But it's good to deprecate them anyway and remove it all at once.

@ElePT ElePT enabled auto-merge October 30, 2024 13:30
@ElePT ElePT added this pull request to the merge queue Oct 30, 2024
Merged via the queue into Qiskit:main with commit 33ed182 Oct 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate qiskit.result.mitigation LocalReadoutMitigator does not support BackendV2
4 participants