Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Python 3.13 #13309

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Add official support for Python 3.13 #13309

merged 7 commits into from
Oct 25, 2024

Conversation

mtreinish
Copy link
Member

Summary

This commit adds "official" support for Python 3.13 to Qiskit. We implicitly supported it previously because nothing in Qiskit itself was incompatible with 3.13 and we use the stable ABI from rust which is compatible with new releases. But to mark 3.13 as "official" we just need to add it to CI, including the cibuildwheel test phase, and add the trove classifier to the package metadata indicating 3.13 is supported.

Details and comments

This commit adds "official" support for Python 3.13 to Qiskit. We
implicitly supported it previously because nothing in Qiskit itself was
incompatible with 3.13 and we use the stable ABI from rust which is
compatible with new releases. But to mark 3.13 as "official" we just
need to add it to CI, including the cibuildwheel test phase, and add the
trove classifier to the package metadata indicating 3.13 is supported.
@mtreinish mtreinish added the Changelog: New Feature Include in the "Added" section of the changelog label Oct 10, 2024
@mtreinish mtreinish added this to the 1.3.0 milestone Oct 10, 2024
@mtreinish mtreinish requested a review from a team as a code owner October 10, 2024 18:33
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11524531528

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.007%) to 88.664%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.24%
crates/qasm2/src/lex.rs 5 91.98%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 11517799526: 0.007%
Covered Lines: 74886
Relevant Lines: 84460

💛 - Coveralls

@mtreinish
Copy link
Member Author

mtreinish commented Oct 14, 2024

This is currently blocked on: #12655 and #13305 because we need to use scipy 1.14 to get wheels with python 3.13 support.

@mtreinish mtreinish added the ci: test wheels Run the wheel-build scripts as an additional CI run for this PR label Oct 25, 2024
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a quick scan myself, looks like we also have the Python versions set in asv.conf.json. Otherwise this looks fine to me.

@mtreinish
Copy link
Member Author

On a quick scan myself, looks like we also have the Python versions set in asv.conf.json. Otherwise this looks fine to me.

Added in fa8a8df

@jakelishman
Copy link
Member

I'm fine with whatever ordering of "change the branch-protection rules" and/or "admin-merge this PR first" you want to go with. It's not like there's a huge demand for the merge queue on a Friday evening.

@mtreinish mtreinish merged commit f10da22 into Qiskit:main Oct 25, 2024
24 of 25 checks passed
@mtreinish mtreinish deleted the py313 branch October 25, 2024 21:01
@jakelishman jakelishman mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog ci: test wheels Run the wheel-build scripts as an additional CI run for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants