Implement arithmetic on SparseObservable
#13298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
on hold
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11576212029Details
💛 - Coveralls |
The simple arithmetic operators of addition, subtraction, multiplication, division and tensor product are in line with other `quantum_info` objects, including coercion from other objects (though better behaved on failed coercions, in many cases). Where appopriate, in-place operations will re-use the existing allocations. The tensor product cannot really be done in place, so it doesn't define a special `__rxor__` operator, but it inherits the standard Python behaviour of this being derived from `__xor__`. There are further mathematical operations to add around composition and evolution, and to apply a `TranspileLayout` to the observable. All of these, in the `quantum_info` style either directly deal with a layout, or take a `qargs` argument that is effectively a sublayout for the right-hand side of the operation. These will be added in a follow-up.
jakelishman
force-pushed
the
sparse-observable-maths
branch
from
bbc5137
to
68b5c56
Compare
|
Now rebased and ready for review. |
Cryoris
reviewed
Oct 25, 2024
Cryoris
reviewed
Oct 25, 2024
Cryoris
reviewed
Oct 25, 2024
Cryoris
reviewed
Oct 25, 2024
Cryoris
reviewed
Oct 25, 2024
This puts the `self is other` check into the `__add__` and `__sub__` methods so that the behaviour of `x + x` is consistent with `x += x`, with regards to the addition being done as a scalar multiplication instead of concatentation. Both forms are mathematically correct, but this makes sure they're aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The simple arithmetic operators of addition, subtraction, multiplication, division and tensor product are in line with other
quantum_infoobjects, including coercion from other objects (though better behaved on failed coercions, in many cases).Where appopriate, in-place operations will re-use the existing allocations. The tensor product cannot really be done in place, so it doesn't define a special
__rxor__operator, but it inherits the standard Python behaviour of this being derived from__xor__.There are further mathematical operations to add around composition and evolution, and to apply a
TranspileLayoutto the observable. All of these, in thequantum_infostyle either directly deal with a layout, or take aqargsargument that is effectively a sublayout for the right-hand side of the operation. These will be added in a follow-up.Details and comments
Built on top of #12671, so depends on it.