Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub source code links on Windows docs builds (backport #13292) #13293

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

Per https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.as_posix, calling str() on a Windows Path object uses \ as the separator. We need to use / for the GitHub URL to work properly.


This is an automatic backport of pull request #13292 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner October 7, 2024 21:50
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Oct 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11224556151

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 89.747%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 92.48%
Totals Coverage Status
Change from base Build 11219525131: -0.003%
Covered Lines: 66885
Relevant Lines: 74526

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Oct 7, 2024
Merged via the queue into stable/1.2 with commit f5c005c Oct 7, 2024
18 checks passed
@Eric-Arellano Eric-Arellano deleted the mergify/bp/stable/1.2/pr-13292 branch October 8, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants