Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the condition attribute and related functionality #13223

Merged
merged 13 commits into from
Oct 31, 2024

Commits on Sep 25, 2024

  1. Deprecate the condition attribute and related functionality

    This commit deprecates the Instruction.condition and c_if() method for
    removal in 2.0. This functionality has been superseded by the more
    sophisiticated `IfElseOp` for some time now. Removing the condition
    property will simplify the Qiskit data model as it is implemented in
    a kind of ad-hoc manner that adds additional overhead to manually check
    it in many places.
    
    For the unittest modifications the deprecation warning for the .condtion
    getter is suppressed for the entire suite because this gets triggered
    internally by the transpiler and a lot of other places, including from
    rust code as until it is removed we need to use it to check that piece
    of the data model.
    
    Fixes Qiskit#9556
    mtreinish committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9259102 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Add missing assertWarns

    mtreinish committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3669504 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ce9f3f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ecd2976 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Elena Peña Tapia <[email protected]>
    mtreinish and ElePT authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    576b523 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    5edf528 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4c868a View commit details
    Browse the repository at this point in the history
  3. Avoid deprecation warning in non-deprecated code

    This commit fixes some places in the code where we were using the
    deprecated functionality where it needed a path to persist the behavior
    or where the deprecation warning became a performance bottleneck. The
    code is updated accordingly and to catch issues like this in the future
    the warning filters are adjusted to be more selective.
    mtreinish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    86914e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add missing test updates

    mtreinish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    099b610 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    1987fb2 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    4bf68ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    706d24d View commit details
    Browse the repository at this point in the history
  3. Fix lint

    mtreinish committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5a77b3e View commit details
    Browse the repository at this point in the history