-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the condition attribute and related functionality #13223
Merged
Commits on Sep 25, 2024
-
Deprecate the condition attribute and related functionality
This commit deprecates the Instruction.condition and c_if() method for removal in 2.0. This functionality has been superseded by the more sophisiticated `IfElseOp` for some time now. Removing the condition property will simplify the Qiskit data model as it is implemented in a kind of ad-hoc manner that adds additional overhead to manually check it in many places. For the unittest modifications the deprecation warning for the .condtion getter is suppressed for the entire suite because this gets triggered internally by the transpiler and a lot of other places, including from rust code as until it is removed we need to use it to check that piece of the data model. Fixes Qiskit#9556
Configuration menu - View commit details
-
Copy full SHA for 9259102 - Browse repository at this point
Copy the full SHA 9259102View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3669504 - Browse repository at this point
Copy the full SHA 3669504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce9f3f - Browse repository at this point
Copy the full SHA 0ce9f3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd2976 - Browse repository at this point
Copy the full SHA ecd2976View commit details -
Apply suggestions from code review
Co-authored-by: Elena Peña Tapia <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 576b523 - Browse repository at this point
Copy the full SHA 576b523View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5edf528 - Browse repository at this point
Copy the full SHA 5edf528View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4c868a - Browse repository at this point
Copy the full SHA d4c868aView commit details -
Avoid deprecation warning in non-deprecated code
This commit fixes some places in the code where we were using the deprecated functionality where it needed a path to persist the behavior or where the deprecation warning became a performance bottleneck. The code is updated accordingly and to catch issues like this in the future the warning filters are adjusted to be more selective.
Configuration menu - View commit details
-
Copy full SHA for 86914e8 - Browse repository at this point
Copy the full SHA 86914e8View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 099b610 - Browse repository at this point
Copy the full SHA 099b610View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1987fb2 - Browse repository at this point
Copy the full SHA 1987fb2View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bf68ea - Browse repository at this point
Copy the full SHA 4bf68eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 706d24d - Browse repository at this point
Copy the full SHA 706d24dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a77b3e - Browse repository at this point
Copy the full SHA 5a77b3eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.