Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipping of slow tests (backport #13119) #13122

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 10, 2024

Summary

Tests with the @slow_test decorators should only be run on-demand, but currently are executed in every CI run. We likely didn't notice this since there is only a single slow test at the moment.

Details and comments

It looks like a tiny logic bug, missing a not 🙂 If necessary, we could maybe add a test setting the environment variable QISKIT_TEST, but it seems straightforward enough as fix and works as expected locally.

No reno as this is not user facing.


This is an automatic backport of pull request #13119 done by Mergify.

(cherry picked from commit d14eb9c)
@mergify mergify bot requested a review from a team as a code owner September 10, 2024 14:51
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Sep 10, 2024
@github-actions github-actions bot added this to the 1.2.1 milestone Sep 10, 2024
@Cryoris
Copy link
Contributor

Cryoris commented Sep 10, 2024

We need to backport this in order to merge #13114 onto stable/1.2

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10795032594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 89.78%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 3 93.23%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10735835379: 0.0%
Covered Lines: 66862
Relevant Lines: 74473

💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Sep 10, 2024
Merged via the queue into stable/1.2 with commit 7f60c17 Sep 10, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13119 branch September 10, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants