Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter aer warnings in deprecated FakeBackend V1 class (backport #13018) #13020

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 23, 2024

Summary

The recent qiskit-aer 0.15 release has introduced deprecation warnings for BackendV1 inputs in NoiseModel.from_backend. We were using this method in the deprecated FakeBackend class (which is, by definition, V1) and this is triggering test failures. I suggest filtering the warnings in FakeBackend until the class is removed in 2.0.

Details and comments


This is an automatic backport of pull request #13018 done by [Mergify](https://mergify.com).

* Filter aer warnings in fake backend for the deprecated V1 path

* Filter warnings in QiskitTestCase instead of catching them

(cherry picked from commit 6b6efc7)
@mergify mergify bot requested a review from a team as a code owner August 23, 2024 11:43
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Aug 23, 2024
@ElePT ElePT enabled auto-merge August 23, 2024 11:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10525115495

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.006%) to 89.816%

Files with Coverage Reduction New Missed Lines %
qiskit/circuit/instruction.py 1 95.64%
qiskit/providers/backend_compat.py 1 89.19%
crates/qasm2/src/expr.rs 1 94.02%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.39%
crates/qasm2/src/lex.rs 6 91.73%
Totals Coverage Status
Change from base Build 10506117955: 0.006%
Covered Lines: 66810
Relevant Lines: 74385

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Aug 23, 2024
Merged via the queue into stable/1.2 with commit 1be2c5a Aug 23, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13018 branch August 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants