Fix AnnotatedOperation
being modified during parameter assignment (backport #12869)
#12872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copying an annotated operation currently does not copy the underlying
base_op
. This leads to problems down the line, as we have multiple annotated operations referencing the samebase_op
, for example in parameter assignment. This PR copies thebase_op
upon copying the annotated operation to fix this problem.Details and comments
No reno (yet), as this bug was probably mostly noticable in this release (1.2) which adds parameter handling to
AnnotatedOperation
.Here's a minimal breaking example, which is fixed by this PR.
This is an automatic backport of pull request #12869 done by [Mergify](https://mergify.com).