Suppress nonsense DeprecationWarning caused by unittest
#12676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
type: qa
|
One or more of the following people are relevant to this code:
|
`unittest.TestCase.assertWarns` in context-manager form has an awkward habit of querying the `__warningregistry__` attribute on every module in existence. This interacts poorly with a Numpy 2 deprecation warning trigger for code that's attempting to import functions from modules that became private in Numpy 2, if a warning has previously been triggered out of `numpy.linalg._linalg`. This simply suppresses that particular warning from the test suite.
jakelishman
force-pushed
the
numpy-warnings
branch
from
541dae4
to
3447642
Compare
jakelishman
force-pushed
the
numpy-warnings
branch
from
66d1421
to
e1b4adc
Compare
Pull Request Test Coverage Report for Build 9705924154Details
💛 - Coveralls |
Cryoris
reviewed
Jun 28, 2024
| @@ -7,6 +7,10 @@ scipy<1.11; python_version<'3.12' | |||
| # See https://github.com/Qiskit/qiskit/issues/12655 for current details. | |||
| scipy==1.13.1; python_version=='3.12' | |||
|
|
|||
| # Rustworkx 0.15.0 contains a bug that breaks graphviz-related tests. | |||
There was a problem hiding this comment.
Is this then unrelated to the NumPy deprecation warning? Edit: Nvm just saw the offline discussion 🙂
There was a problem hiding this comment.
Yes, it's just that Rustworkx 0.14 wasn't compatible with Numpy 2 and Rustworkx 0.15 is, so the release caused us to start pulling in Numpy 2 in CI. We didn't see the failures before because not only do you need Numpy 2, you also need to have the test suite generate a warning out of np.linalg._linalg, which we don't do on most platforms, but there are some about numerical-precision things on macOS ARM specifically, and we weren't running the Numpy 2 tests on macOS ARM previously because it wasn't available to us at the time.
Eric-Arellano
previously approved these changes
Jun 28, 2024
ElePT
previously approved these changes
Jun 28, 2024
Pull Request Test Coverage Report for Build 9710892224Details
💛 - Coveralls |
Co-authored-by: Elena Peña Tapia <[email protected]>
Pull Request Test Coverage Report for Build 9712800437Details
💛 - Coveralls |
ElePT
approved these changes
Jun 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Suppress nonsense `DeprecationWarning` caused by `unittest` `unittest.TestCase.assertWarns` in context-manager form has an awkward habit of querying the `__warningregistry__` attribute on every module in existence. This interacts poorly with a Numpy 2 deprecation warning trigger for code that's attempting to import functions from modules that became private in Numpy 2, if a warning has previously been triggered out of `numpy.linalg._linalg`. This simply suppresses that particular warning from the test suite. * Refine filter * Pin Rustworkx to avoid buggy graphviz drawing * Update test/utils/base.py Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 3adcd5d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
…12687) * Suppress nonsense `DeprecationWarning` caused by `unittest` `unittest.TestCase.assertWarns` in context-manager form has an awkward habit of querying the `__warningregistry__` attribute on every module in existence. This interacts poorly with a Numpy 2 deprecation warning trigger for code that's attempting to import functions from modules that became private in Numpy 2, if a warning has previously been triggered out of `numpy.linalg._linalg`. This simply suppresses that particular warning from the test suite. * Refine filter * Pin Rustworkx to avoid buggy graphviz drawing * Update test/utils/base.py Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 3adcd5d) Co-authored-by: Jake Lishman <[email protected]>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…2676) * Suppress nonsense `DeprecationWarning` caused by `unittest` `unittest.TestCase.assertWarns` in context-manager form has an awkward habit of querying the `__warningregistry__` attribute on every module in existence. This interacts poorly with a Numpy 2 deprecation warning trigger for code that's attempting to import functions from modules that became private in Numpy 2, if a warning has previously been triggered out of `numpy.linalg._linalg`. This simply suppresses that particular warning from the test suite. * Refine filter * Pin Rustworkx to avoid buggy graphviz drawing * Update test/utils/base.py Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unittest.TestCase.assertWarnsin context-manager form has an awkward habit of querying the__warningregistry__attribute on every module in existence. This interacts poorly with a Numpy 2 deprecation warning trigger for code that's attempting to import functions from modules that became private in Numpy 2, if a warning has previously been triggered out ofnumpy.linalg._linalg.This simply suppresses that particular warning from the test suite.
Details and comments