Add placeholders for all mising standard gates in Rust #12646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9644456868Details
💛 - Coveralls |
ElePT
commented
Jun 24, 2024
Pull Request Test Coverage Report for Build 9645642831Details
💛 - Coveralls |
This was referenced Jun 24, 2024
ElePT
commented
Jun 24, 2024
Pull Request Test Coverage Report for Build 9648750761Details
💛 - Coveralls |
ElePT
added
Changelog: None
mtreinish
approved these changes
Jun 24, 2024
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* Add placeholders for all gates, mark TODOs * Update name for CPhase * Remove todo from Ux gates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes placeholders for all missing gates in #12566 with a dummy number of qubits and number of parameters (34) that should be replaced with the actual number when implemented. The idea of this proposal is to allow for a better parallelization of the work that avoids conflicts. Note that I don't particularly like this order, and I think we should reorder the lists once the implementations are completed, but I think this order is better than having to resolve conflicts every time we merge a new PR. I have also added annotations in the static vectors to increase readability.
Details and comments