Fix v2 pulse drawer #12608
Merged
Fix v2 pulse drawer #12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkanazawa1989
added
the
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9592725734Details
💛 - Coveralls |
ElePT
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Thanks for the fix @nkanazawa1989, if you'd like we can try to include it in the 1.1.1 release today, I want to do it in a few hours, so all we need is for lint to pass (added a suggestion below). Else, we can always just add it to 1.2.
| qubit_channel_map[qind].extend(configuration.control(qubits=(qind, tind))) | ||
| except BackendConfigurationError: | ||
| pass | ||
| elif isinstance(backend, BackendV2): |
There was a problem hiding this comment.
Lint is complaining about this being an elif instead of an else. I think it is reasonable to assume that the default is BackendV2 and not do the instance check
There was a problem hiding this comment.
The other thing we sometimes do is to be more defensive and do the check, in order to raise an explicit RuntimeError("backend object not yet supported") for a clearer message - we don't have a BackendV3, but it's not inconceivable that we will expand in the future and have this same bug again.
ElePT
reviewed
Jun 20, 2024
ElePT
added
the
stable backport potential
ElePT
reviewed
Jun 20, 2024
ElePT
previously approved these changes
Jun 20, 2024
|
https://github.com/Mergifyio backport stable/0.46 stable/1.1 |
✅ Backports have been created
|
Pull Request Test Coverage Report for Build 9596352057Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
approved these changes
Jun 20, 2024
Pull Request Test Coverage Report for Build 9596940272Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix error when V2 model is set * Apply suggestions from code review * Fix black --------- Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 7d1731b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix error when V2 model is set * Apply suggestions from code review * Fix black --------- Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 7d1731b)
This was referenced Jun 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix error when V2 model is set * Apply suggestions from code review * Fix black --------- Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 7d1731b) Co-authored-by: Naoki Kanazawa <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix error when V2 model is set * Apply suggestions from code review * Fix black --------- Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 7d1731b) Co-authored-by: Naoki Kanazawa <[email protected]>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* fix error when V2 model is set * Apply suggestions from code review * Fix black --------- Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v2 pulse drawer crashes when the draw function is called with a V2 backend that doesn't have configuration and defaults attributes. Since qiskit-ibm-runtime 0.24 was released and fake V1 backends were deprecated, we should to support visualization with fake V2 backends that doen't have configuration and defaults attributes.
Details and comments