-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized apply_operation_back for DAGDependencyV2 #12194
Open
enavarro51
wants to merge
32
commits into
Qiskit:main
Choose a base branch
from
enavarro51:dag_dep_apply
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 9705468617Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9714236322Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
enavarro51
changed the title
[WIP] Optimized apply_operation_back for DAGDependencyV2
Optimized apply_operation_back for DAGDependencyV2
Jul 2, 2024
Pull Request Test Coverage Report for Build 9754486878Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optimized version of
apply_operation_back
toDAGDependencyV2
. Requiresrustworkx
0.15.0Details and comments
This PR updates
apply_operation_back
inDAGDependencyV2
to use several optimized functions forTopologicalSorter
in the 0.15.0 release ofrustworkx
. These include aninitial
option to include a list of starting nodes, acheck_args
option to eliminate some checks in the sorter, and allowing thedone
function to accept an int as well as a list.In local tests on a random clifford circuit, this reduced the execution time of converting from a circuit to a
DAGDependencyV2
from 35 sec to 1.9 sec.Requires rustworkx 0.15.0.