Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observable container type for Estimator #11594

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    942d997 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Remove basis validation from Observable/ObservableArray

    The intent is that an Estimator can retrieve the basis terms in an observables array from the `terms` attribute and validate them itself, rather than hard code the allowed terms here. If we do still want to hardcode this in the classes we could add it back, but the current version of expecting subclasses to override ALLOWED_BASIS doesn't work with the current implementation of class methods which done return the subclass type from methods like reshape etc
    chriseclectic committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f8bf6c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Change Observable key type

    This changes the mapping key type to be `(tuple[int], str)` instead of str, to allow for sparse representations in the future. Eg instead of `"XIIIY" you can have `((0, 5,), "XY")`. Also removes validation of allowed characters in the strings. Still need to update unit tests if we go with this.
    chriseclectic committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ae5ee53 View commit details
    Browse the repository at this point in the history
  2. Fix some typos

    chriseclectic committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4315907 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    0fae636 View commit details
    Browse the repository at this point in the history