Improve registry validation #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
requested review from
akihikokuroda,
IceKhan13 and
psschwei
and removed request for
akihikokuroda
IceKhan13
reviewed
Aug 1, 2024
| ) | ||
| if not provider_instance.registry or not image.startswith( | ||
| raise ValidationError(f"{provider} is not valid provider.") | ||
| if provider_instance.registry and not image.startswith( |
There was a problem hiding this comment.
Are we sure here that provider_instance always has registry attribute?
There was a problem hiding this comment.
you mean if the registry from provider_instance can be None? The answer is yes. What I'm trying to do here is that if it's None it's ok, we accept any value in the image.
There was a problem hiding this comment.
Until now we were forcing it to have a value but there are situations where it can has no sense like in local development.
IceKhan13
approved these changes
Aug 1, 2024
Tansito
added a commit
that referenced
this pull request
Aug 1, 2024
* Applied #1429 in 0.14 * Update 0.14 patch version * Updated helm lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1428
Let's simplify the logic of the registry validation to allow that if a registry is not specified the provider can use any registry that it wants. Specifically useful for development.