Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scripts instead of notebooks for tests #1239

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Mar 6, 2024

Summary

Run tests against python scripts instead of jupyter notebooks

Details and comments

There's two reasons for doing this:

Note that the decorators test fails (xref #1238)

@psschwei
Copy link
Collaborator Author

psschwei commented Mar 6, 2024

We also now see all the warnings when the LocalProvider tries to use unimplemented file methods : https://github.com/Qiskit-Extensions/quantum-serverless/actions/runs/8177774823/job/22360183087?pr=1239

@Tansito
Copy link
Member

Tansito commented Mar 6, 2024

Oh wow, good refactorization @psschwei . Is it ready for review or are you testing something more?

@psschwei
Copy link
Collaborator Author

psschwei commented Mar 6, 2024

Is it ready for review or are you testing something more?

Ready for review 😄

@Tansito
Copy link
Member

Tansito commented Mar 12, 2024

Do you update this pull request with the last change fixing the decorator, @psschwei ? I can take a look into this tomorrow 🙏

@psschwei
Copy link
Collaborator Author

I'll rebase now

Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of the pull request. My only comment @psschwei is if you could check if we can remove nbmake dependency with this from the requirements:

https://github.com/Qiskit-Extensions/quantum-serverless/blob/main/client/requirements-dev.txt#L20

I think we don't need it with these last changes but I'm not sure 😅

Signed-off-by: Paul S. Schweigert <[email protected]>
@Tansito Tansito self-requested a review March 14, 2024 13:49
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @psschwei ! LGTM 😄

@psschwei psschwei merged commit a438ad6 into Qiskit:main Mar 14, 2024
15 checks passed
@psschwei psschwei deleted the e2e-tests branch March 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants