-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore pip-tools for dependency management #1081
Conversation
client/requirements.in
Outdated
@@ -0,0 +1,16 @@ | |||
ray[default,data]>2.6<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting errors when this was unpinned. One requirements file would install ray 2.3 and one would install ray 2.6, which led to conflicts between the dev and production envs.
…e pip-sync in client tests for debugging.
Thanks @caleb-johnson ! I will start taking a look into this too. Thank you to start with! ❤️ |
I'm assuming the answer to this is yes, but we should confirm that dependabot will handle updates on |
Well, I would not assume it to be honest. Definitely one of the things that we will need to see 😂 |
@@ -6,7 +6,6 @@ | |||
|
|||
|
|||
class Migration(migrations.Migration): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of annoying to have to update these files (migrations 0011, 0012) in this PR, but the black version being resolved for the gateway wants this fixed :)
commands = | ||
pip-sync requirements-dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be totally redundant. Need to double check
@caleb-johnson @Tansito any updates on this? should we close it? |
I think it is OK to close for now, and if @Tansito or anyone decides they would like to migrate to |
Fixes #901
I opened this PR to play around with
pip-tools
and continue the discussion in #901.With this tool, instead of only specifying our top-most dependencies, we allow pip-tools to create our
requirements.txt
from arequirements.in
. Therequirements.in
is very similar to our currentrequirements.txt
, but it generally has its version restrictions relaxed to the maximum extent. This allowspip-tools
to do much of the dependency management for us. Therequirements.txt
generated includes a fully resolved dependency tree, reducing the chances of conflicts during installation.pip-compile
frompip-tools