Fix upload serialization argument vs env_vars

Qiskit · Mar 13, 2024 · e2a6e82 · e2a6e82
1 parent 490a6ab
commit e2a6e82
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/gateway/api/v1/serializers.py b/gateway/api/v1/serializers.py
@@ -16,7 +16,7 @@ class Meta(serializers.ProgramSerializer.Meta):
             "entrypoint",
             "artifact",
             "dependencies",
-            "env_vars",
+            "arguments",
             "public",
         ]
 
@@ -38,8 +38,7 @@ class Meta(serializers.UploadProgramSerializer.Meta):
             "entrypoint",
             "artifact",
             "dependencies",
-            "env_vars",
-            "public",
+            "arguments",
         ]
 
 

diff --git a/gateway/tests/api/test_v1_serializers.py b/gateway/tests/api/test_v1_serializers.py
@@ -55,13 +55,13 @@ def test_upload_program_serializer_creates_program(self):
 
         title = "Hello world"
         entrypoint = "pattern.py"
-        env_vars = "{}"
+        arguments = "{}"
         dependencies = "[]"
 
         data = {}
         data["title"] = title
         data["entrypoint"] = entrypoint
-        data["env_vars"] = env_vars
+        data["arguments"] = arguments
         data["dependencies"] = dependencies
         data["artifact"] = upload_file
 
@@ -71,7 +71,7 @@ def test_upload_program_serializer_creates_program(self):
         program: Program = serializer.save(author=user)
         self.assertEqual(title, program.title)
         self.assertEqual(entrypoint, program.entrypoint)
-        self.assertEqual(env_vars, program.env_vars)
+        self.assertEqual(arguments, program.arguments)
         self.assertEqual(dependencies, program.dependencies)
 
     def test_upload_program_serializer_fails_at_validation(self):
@@ -86,8 +86,6 @@ def test_upload_program_serializer_fails_at_validation(self):
             "artifact.tar", data.read(), content_type="multipart/form-data"
         )
 
-        user = models.User.objects.get(username="test_user")
-
         title = "Hello world"
         entrypoint = "pattern.py"
 
@@ -98,15 +96,15 @@ def test_upload_program_serializer_fails_at_validation(self):
         errors = serializer.errors
         self.assertListEqual(["title", "entrypoint", "artifact"], list(errors.keys()))
 
-        env_vars = {}
+        arguments = {}
         dependencies = []
         data["title"] = title
         data["entrypoint"] = entrypoint
         data["artifact"] = upload_file
-        data["env_vars"] = env_vars
+        data["arguments"] = arguments
         data["dependencies"] = dependencies
 
         serializer = UploadProgramSerializer(data=data)
         self.assertFalse(serializer.is_valid())
         errors = serializer.errors
-        self.assertListEqual(["dependencies", "env_vars"], list(errors.keys()))
+        self.assertListEqual(["dependencies", "arguments"], list(errors.keys()))