Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose service errors to users #8

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Expose service errors to users #8

merged 10 commits into from
Jul 17, 2024

Conversation

y4izus
Copy link
Collaborator

@y4izus y4izus commented Jul 10, 2024

Summary

Fix #2

Details and comments

To check the code, we first checked the swagger to see the service errors coming from the transpile endpoint. Then we run the ai-transpiler-demo jupyter notebook to test through the client and check if we get the same error messages.

We did some checks to make sure error messages are exposed:

  • Try to access a backend we don't have access to
  • Try to access a backend that doesn't exist
  • Try to run a circuit with more gates than allowed
  • An input with wrong format
  • I was asked to try to run a task by an unexisting id, but it looks like this check makes no sense on the client
  • Try to run a task that is failing. We had this code that was failing, but we checked it and it works, so we don't know how to try this check. If any of you have an idea, please let me know Thank you @jesus-talavera-ibm for your help here

Tests have been created to check the error messages

Thank you @victor-villar for helping me building the code to check the different situations

@y4izus y4izus marked this pull request as draft July 10, 2024 11:27
@y4izus y4izus marked this pull request as ready for review July 10, 2024 14:06
@y4izus y4izus marked this pull request as draft July 12, 2024 13:47
@y4izus y4izus marked this pull request as ready for review July 15, 2024 10:35
Copy link
Contributor

@jesus-talavera-ibm jesus-talavera-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@victor-villar victor-villar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@y4izus y4izus merged commit 497bb99 into main Jul 17, 2024
10 checks passed
@y4izus y4izus deleted the yg-expose-errors-to-users branch July 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose to the user errors coming from the service
3 participants