Update unit tests for Qiskit 1.3 #2041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
commented
Nov 13, 2024
| @@ -85,7 +85,7 @@ def test_raise_faulty_edge(self): | |||
| circ.cx(i, i + 1) | |||
|
|
|||
| transpiled = transpile(circ, backend=fake_backend) | |||
| edge_qubits = [0, 1] | |||
| edge_qubits = [1, 2] | |||
There was a problem hiding this comment.
I'm not sure what changed here but these tests fail with (0,1)
kt474
commented
Nov 13, 2024
| @@ -870,49 +868,6 @@ def test_registers(self): | |||
|
|
|||
| self.assertEqual(expected, scheduled) | |||
|
|
|||
| def test_c_if_plugin_conversion_with_transpile(self): | |||
There was a problem hiding this comment.
Looks like the c_if control flow is no longer supported so I think we can remove these tests?
'c_if control-flow is not supported by this pass. Please apply "ConvertConditionsToIfOps" to convert these conditional operations to new-style Qiskit control-flow.
kt474
commented
Nov 13, 2024
| @@ -291,7 +290,7 @@ def _top_ord(dag): | |||
|
|
|||
| midmeas_dd = pm.run(self.midmeas) | |||
|
|
|||
| combined_u = UGate(3 * pi / 4, -pi / 2, pi / 2) | |||
| combined_u = UGate(pi, 0, pi) | |||
There was a problem hiding this comment.
Also not sure about this change
kt474
commented
Nov 13, 2024
| op = instruction.operation | ||
| if isinstance(op, RXGate): | ||
| self.assertEqual(op.duration, rx_duration) | ||
|
|
There was a problem hiding this comment.
I believe this is failing because duration is deprecated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wip
Details and comments
Fixes #2023