Add generic channel for custom channel platformsGeneric channels #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
would be the the right label, I assume? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generic channel code as developed by Jonas @javajonny Maurer as part of his internship, so full credits to him. I slightly simplified the code (removing debug statements) and added some text for release notes/README.md, as his internship ended, and re-tested things using a POC of a custom channel platform running locally (that is not publicly available at this time).
Details and comments
This takes pass at #1842 .
Testing -- I didn't see any concerns in unit tests; no tests added though since the intention of the generic channel is to have qiskit-ibm-runtime do minimal checking and mangling of parameters (such as no magic applied to url etc.).