Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the solve_dice function #43

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Remove the solve_dice function #43

merged 7 commits into from
Nov 7, 2024

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Nov 6, 2024 •
edited
Loading

Fixes #28

This PR:

  • Removes solve_dice
  • Gets rid of incorrect "address" language throughout source

kevinsung
kevinsung approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@kevinsung kevinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this close #28 ?

@caleb-johnson
Copy link
Collaborator Author

Does this close #28 ?

yes thank you

@caleb-johnson caleb-johnson merged commit e3a47cc into main Nov 7, 2024
5 checks passed
@caleb-johnson caleb-johnson deleted the addr-cleanup branch November 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsung kevinsung kevinsung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove addresses language from package
2 participants
@caleb-johnson @kevinsung