Fix test to reflect latest changes to solve_fermion and qiskit-addon-sqd #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsung
reviewed
Sep 25, 2024
| @@ -119,4 +109,4 @@ | |||
| e_hist[i, :] = int_e | |||
|
|
|||
| print(f"Exact energy: -109.10288938") | |||
| print(f"Estimated energy: {np.min(e_hist[-1]) + nuclear_repulsion_energy}") | |||
| print(f"Estimated energy: {np.min(e_hist[-1])}") | |||
There was a problem hiding this comment.
Should this test have an assert statement?
There was a problem hiding this comment.
Yes I've been using this as a personal sanity check test, rather than something that runs in any automated way. I'm eventually going to try and write a Docker test that runs this in Ubuntu 24.04 in an automated way.
This line was just an artifact of an old workflow and caused the NRE to be applied twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
mpirun_options = "some string"to break the Dice command line call