Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

feat: remove noreferrer #2188

Merged
merged 1 commit into from
Aug 24, 2023
Merged

feat: remove noreferrer #2188

merged 1 commit into from
Aug 24, 2023

Conversation

eddybrando
Copy link
Contributor

@eddybrando eddybrando commented Aug 24, 2023 •
edited
Loading

When linking to external links, we want to preserve noopener but remove noreferrer.

Changes

This PR removes the noreferrer keyword for the external link since we want to be able to use the Referer header.

Related to Qiskit/qiskit.org#3514

@eddybrando eddybrando added the feature New features and enhancements. label Aug 24, 2023
@eddybrando eddybrando self-assigned this Aug 24, 2023
@eddybrando eddybrando changed the title feat: remove feat: remove noreferrer Aug 24, 2023
abdonrd
abdonrd approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It works in the preview!

@abdonrd abdonrd merged commit c155f0a into main Aug 24, 2023
4 checks passed
@abdonrd abdonrd deleted the feat/remove-noreferrer branch August 24, 2023 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abdonrd abdonrd abdonrd approved these changes

@vabarbosa vabarbosa Awaiting requested review from vabarbosa vabarbosa is a code owner

@korgan00 korgan00 Awaiting requested review from korgan00 korgan00 is a code owner

@techtolentino techtolentino Awaiting requested review from techtolentino

@y4izus y4izus Awaiting requested review from y4izus

Assignees

@eddybrando eddybrando

Labels
feature New features and enhancements.
Projects
Qiskit.org
Status: 👋 Past sprints
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddybrando @abdonrd