Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

feat: 1XP banner #2180

Merged
merged 6 commits into from
Aug 18, 2023
Merged

feat: 1XP banner #2180

merged 6 commits into from
Aug 18, 2023

Conversation

eddybrando
Copy link
Contributor

@eddybrando eddybrando commented Aug 11, 2023

🚨 Important: Do not merge yet! Only merge when scheduled and after replacing the links.


Changes

This PR adds the 1XP banners to the course pages.

Closes #2158

image

Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @eddybrando looks good. can you get confirmation from design on how to treat the below scenario?

server/templates/textbook.pug Show resolved Hide resolved
@eddybrando eddybrando removed the feature New features and enhancements. label Aug 14, 2023
vabarbosa
vabarbosa previously approved these changes Aug 14, 2023
Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddybrando thank you!!!
only thing is to remember to update the URL before merging :-)
thanks again

Copy link
Contributor

@techtolentino techtolentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks @eddybrando

@eddybrando eddybrando merged commit cda50c9 into main Aug 18, 2023
4 checks passed
@eddybrando eddybrando deleted the feat/1xp-banner branch August 18, 2023 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a banner to announce the new Learning Platform
4 participants