Add missing public interfaces to ASG #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
jakelishman
commented
Jan 16, 2024
Comment on lines
+313
to
+315
| pub fn identifier(&self) -> &SymbolIdResult { | ||
| &self.identifier | ||
| } |
There was a problem hiding this comment.
Fwiw, this return type isn't ideal from an interface, but it's consistent with the rest of the library for now so we can fix the rest later.
Ideally, all the Result objects would get resolved (or auto-unwrapped) and SymbolId would derive Copy (since it's just a usize), then the return type would be SymbolId (or something more strongly typed). If the Result is kept, then Result<&T, &E> is the more useful return type than &Result<T, E>, and you can go from the latter to the former with Result::as_ref, but that's also doable from downstream code, so not the end of the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.