[BUG] Unable to output

[mickahell]

Summary

Do not join logs by "\n" but instead used " " to keep them single line friendly with new GITHUB_OUTPUT variables.

Details and comments

• Update join in return logs
• Fixed 2 depreciations I didn't saw last time
• Update unit tests
• Tests run --> https://github.com/mickahell/ecosystem/actions/runs/5683507039/job/15404220026

---

Closes #458

[mickahell]

@frankharkins I found why and fixed it :) ready for your review

[frankharkins]

Thanks! What do you think about adding a guard to set_actions_output to assert there's no newline characters? Might make it easier to debug in the future.

[mickahell]

@frankharkins do you mean something like :

if "\n" in my_string:
   single_ value = " ".join(line.strip() for line in my_string.splitlines())

?

The thing is we should not break the submission parser, especially the description. I'm telling you that because is was one of my first solution but I broke the submission parser output ^^' (commit 57a9c4654e053fe5111a5e565c017e41f5770a03)

[frankharkins]

I was thinking more

assert "\n" not in my_string, f"Error: Newlines in github output ({my_string})"

so we can see what caused the problem in the action log

[mickahell]

Oh yeah a test case, well see :)
I'll try that

[mickahell]

@frankharkins I applied your suggestion :)
and I did some tests as well : actions 5699620350 and 5699614358 everything is working as expected

[frankharkins]

Awesome! Thank you :)