Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running save-jobs notebook in CI for now #2286

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Nov 11, 2024

The notebook is failing with this:

---------------------------------------------------------------------------
StopIteration                             Traceback (most recent call last)
Cell In[2], line 3
      1 # Get ID of most recent successful job for demonstration.
      2 # This will not work if you've never successfully run a job.
----> 3 successful_job = next(jforjinservice.jobs()ifj.status().name=="DONE")
      4 job_id = successful_job.job_id()
      5 print(job_id)

StopIteration: 

Also closes #2277 by ignoring a valid link.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Eric-Arellano
Copy link
Collaborator Author

Hm, this doesn't work because later cells depend on this cell.

@Eric-Arellano Eric-Arellano changed the title Make save-jobs notebook resilient to no successful jobs Stop running save-jobs notebook in CI for now Nov 11, 2024
@Eric-Arellano
Copy link
Collaborator Author

Follow up tracked by #2287

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 82b3765 Nov 11, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/fix-notebook branch November 11, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extended checks failed
2 participants