address comments

src/QMCWaveFunctions/BsplineFactory/SplineC2C.cpp

@@ -134,15 +134,15 @@ void SplineC2C<ST>::applyRotation(const ValueMatrix& rot_mat, bool use_stored_co
   {
     // if ST is float, RealType is double and ValueType is std::complex<double> for C2C
     // Just use naive matrix multiplication in order to avoid losing precision on rotation matrix
-    for (int i = 0; i < basis_set_size; i++)
-      for (int j = 0; j < OrbitalSetSize; j++)
+    for (IndexType i = 0; i < basis_set_size; i++)
+      for (IndexType j = 0; j < OrbitalSetSize; j++)
       {
         // cur_elem points to the real componend of the coefficient.
         // Imag component is adjacent in memory.
         const auto cur_elem = Nsplines * i + 2 * j;
         ST newval_r{0.};
         ST newval_i{0.};
-        for (auto k = 0; k < OrbitalSetSize; k++)
+        for (IndexType k = 0; k < OrbitalSetSize; k++)
         {
           const auto index = Nsplines * i + 2 * k;
           ST zr            = (*coef_copy_)[index];

src/QMCWaveFunctions/BsplineFactory/SplineR2R.cpp

@@ -131,12 +131,12 @@ void SplineR2R<ST>::applyRotation(const ValueMatrix& rot_mat, bool use_stored_co
   else
   {
     //Here, ST is float but ValueType is double for R2R. Due to issues with type conversions, just doing naive matrix multiplication in this case to not lose precision on rot_mat
-    for (auto i = 0; i < BasisSetSize; i++)
-      for (auto j = 0; j < OrbitalSetSize; j++)
+    for (IndexType i = 0; i < BasisSetSize; i++)
+      for (IndexType j = 0; j < OrbitalSetSize; j++)
       {
         const auto cur_elem = Nsplines * i + j;
-        auto newval{0.};
-        for (auto k = 0; k < OrbitalSetSize; k++)
+        FullPrecValueType newval{0.};
+        for (IndexType k = 0; k < OrbitalSetSize; k++)
         {
           const auto index = i * Nsplines + k;
           newval += (*coef_copy_)[index] * rot_mat[k][j];