Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows adjust spline grid with -m meshfactor #115

Merged
merged 2 commits into from
May 3, 2018

Conversation

ye-luo
Copy link
Collaborator

@ye-luo ye-luo commented May 2, 2018

closes #95.

@ghost ghost assigned ye-luo May 2, 2018
@ghost ghost added the in progress label May 2, 2018
Copy link
Collaborator

@markdewing markdewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I've been wanting this option.

@grahamlopez
Copy link
Contributor

Is there anywhere that new people can find out what exactly this parameter does and how to use it correctly?

@ye-luo
Copy link
Collaborator Author

ye-luo commented May 3, 2018

Three possible places to write this info. command -h printout, doxygen or wiki. Is wiki a better place to explain such details?

@grahamlopez
Copy link
Contributor

Yeah, I'm fine with the wiki. Maybe we can add a single line to the -h printout to remind people of the wiki's existence/location (for help with all options)

@ye-luo
Copy link
Collaborator Author

ye-luo commented May 3, 2018

We actually need a complete header #46

@grahamlopez
Copy link
Contributor

good call. I added a comment to that issue to remind us.

@grahamlopez grahamlopez merged commit 00c6b6a into QMCPACK:develop May 3, 2018
@ghost ghost removed the in progress label May 3, 2018
@ye-luo ye-luo deleted the set-MF branch May 15, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need meshfactor command line option
3 participants