Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better memory management #117

Merged
merged 3 commits into from
Oct 11, 2024
Merged

better memory management #117

merged 3 commits into from
Oct 11, 2024

Conversation

PaulLaux
Copy link
Collaborator

Improved memory management and compatibility by replacing &vec<u8> to &[u8] in some places and some other minor changes.

Copy link

what-the-diff bot commented Oct 11, 2024

PR Summary:

  • Function Signature Modifications to Improve Performance and Memory Usage
    This PR includes changes in our function signatures to use slices instead of vectors for asset descriptions throughout various files. This alteration will enhance our application's performance and reduce memory usage.

  • Optimization of get_all_notes Return Value in issuance.rs
    The get_all_notes function has been modified to return a vector of references instead of owned vectors. This change will avoid unnecessary cloning and improve application performance.

  • Function Renaming for Improved Clarity
    The function formerly known as get_actions_by_base has been renamed to get_actions_by_asset in the file issuance.rs for improved clarity and understandability.

  • Standardization of Formatting and Syntax
    To uphold consistency and clarity in the codebase, minor formatting and syntax changes have been made that do not impact the overall functionality.

@PaulLaux PaulLaux merged commit 30f299b into asset_desc_as_bytes Oct 11, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant