Pre backward compatibility #105
Draft
Annotations
9 warnings
|
Run Clippy:
src/lib.rs#L6
warning: unused imports: `H`, `ValueCommitV`
--> src/constants.rs:6:77
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^^^^^^^^^^^^ ^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Run Clippy:
src/lib.rs#L614
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:614:14
|
614 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
Run Clippy:
src/lib.rs#L808
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:808:10
|
808 | .fold(Some(ValueSum::zero()), |acc, action| {
| __________^
809 | | acc? + action.value_sum()
810 | | })
| |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
Run Clippy:
src/lib.rs#L270
warning: use of a fallible conversion when an infallible one could be used
--> src/keys.rs:270:27
|
270 | self.0.to_bytes().try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
|
270 - self.0.to_bytes().try_into().unwrap()
270 + self.0.to_bytes().into()
|
|
|
Run Clippy:
src/lib.rs#L337
warning: use of a fallible conversion when an infallible one could be used
--> src/keys.rs:337:27
|
337 | self.0.to_bytes().try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
help: use
|
337 - self.0.to_bytes().try_into().unwrap()
337 + self.0.to_bytes().into()
|
|
|
Run Clippy:
src/lib.rs#L353
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption_v3.rs:353:18
|
353 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/f5d04caa74a1dfa5ffc4082c2c8f621f25336bbc/library/core/src/iter/traits/iterator.rs:603:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
Run Clippy:
src/lib.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:226:14
|
226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
Run Clippy:
src/lib.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:232:14
|
232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
Run Clippy
warning: 8 warnings emitted
|
Loading