Upstream update #89
Closed
Upstream update #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rategy-doc
Make the `{fixed,standard,zip317}::SingleOutputChangeStrategy` doc comments more accurate concerning the choice of output pool
…st from `zcash_client_sqlite`
…arent zcash_client_sqlite: Do not require a transparent key for migrations.
Generalize the `zcash_client_sqlite` test framework and extract it to `zcash_client_backend`
We already depend on `rustls` and `webpki-roots` for `tor::http`, but `tonic` has its own feature flag that needs to be enabled for equivalent support in `tor::grpc`. We didn't need that feature flag enabled for the `proto::service::compact_tx_streamer_client` module because those constructors take a `D: TryInto<tonic::transport::Endpoint>`, which abstracts over TLS and leaves it up to the caller. By constrast, in `tor::grpc` we need to construct the `Endpoint` manually from a `Uri` and then configure TLS ourselves.
devtools: Detect more key formats with `zcash-inspect`
zcb::sync: Refresh UTXOs at the start of each scanning cycle
This reduces the feature-flag-related `WalletRead` breakage for crate users, and gives us a place to expose even more internal Data Access API implementation details for general testing purposes.
Addresses review comments from zcash#1530.
zip321: Add missing `test-dependencies` feature configuration.
After splitting recover progress out from scan progress, the overestimation of the chain tip tree size became much more noticeable. We now extrapolate from the most recent known "notes per block" rate.
…ests The wrong subtree was being completed, which didn't matter before but does now that scan progress is extrapolated.
zcash_client_backend: Post-merge cleanups to test framework extraction
…ress Improve progress representation in `WalletSummary`
Signed-off-by: Daira-Emma Hopwood <[email protected]>
[zcash#1411] Refactor AccountBalance to use Balance for transparent funds
`v_tx_outputs` gains new JOINs on `accounts.id` in order to migrate to exposing `accounts.uuid`, but as there are two table joins the tables are given aliases. The aliases were not being used in the JOIN's ON condition, leading to an error when querying the view.
- The Inputs Modifiable Flag and Outputs Modifiable Flag are now only for transparent inputs and outputs. - Bit 7 is now the Shielded Modifiable Flag (a single flag bit is fine because all shielded effects are always committed to at once). - Fixed a bug in `Creator::build_from_parts` where the Has `SIGHASH_SINGLE` Flag was not being set correctly. - The Signer role now updates `tx_modifiable` in case the IO Finalizer role has not yet run (which might be possible in some scenarios).
pczt: Define the structure and semantics of the PCZT format
Co-authored-by: Daira-Emma Hopwood <[email protected]>
…rts. This refactors `create_proposed_transaction` to allow the internal builder state and per-output metadata to be exposed after all inputs and outputs for a proposal step have been added, in order to make it possible to generate a PCZT from this data.
This uses the existing String encoding to avoid defining a new serialization format. It is necessary for `zcash_client_backend` to encode recipient addresses inside PCZTs to enable correct extraction and and storage in the wallet backend.
…al Step. Proving and signing don't require specific wallet methods; the `Prover` and `Signer` roles provide the necessary functionality. Co-authored by: Jack Grigg <[email protected]>
This enables PCZTs to be used when the `serde` feature flag is enabled.
Co-authored-by: Daira-Emma Hopwood <[email protected]>
…ivation zcash_keys: Make address generation use all items of the source key by default.
zcash_client_backend PCZT support
…decov/codecov-action-5.1.1 build(deps): bump codecov/codecov-action from 4.6.0 to 5.1.1
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
from the status checks task. Signed-off-by: Daira-Emma Hopwood <[email protected]>
* Only require tests to pass on Linux. * Remove the confusing and unnecessary "NOT_A_PUZZLE" state. Signed-off-by: Daira-Emma Hopwood <[email protected]>
[Do not merge] CI: Move expensive tests to another task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.