Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Nu6 constants #79

Closed
wants to merge 2 commits into from
Closed

Use correct Nu6 constants #79

wants to merge 2 commits into from

Conversation

alexeykoren
Copy link
Collaborator

  • Use correct Nu6 constants
  • Disable Nu7 activation for the time being

Copy link

what-the-diff bot commented Nov 13, 2024

PR Summary

  • Update of the block height for network upgrade
    The block height, which is the position of a particular transaction in the blockchain, for NetworkUpgrade::Nu6 has been increased from 1_687_106 to 2_726_400. This adjustment will affect the order and positioning of transactions in the network.

  • Setting network upgrade to None
    The NetworkUpgrade::Nu7 was set to None for all the Main, Test, and Regtest networks. This means this particular network upgrade won't have any impact on these specified networks.

  • Modification in tests for new block height
    The integrated test suite has been updated. Now, it checks whether the new block height for NetworkUpgrade::Nu6 is functioning as expected.

  • Change in the local consensus tests
    The local consensus tests now have a new condition in place. They ensure that the NetworkUpgrade::Nu7 is not currently active, thereby helping to maintain stability in the system.

  • Transaction builder update
    The transaction builder was changed to retrieve the activation height (the point at which a particular change in the system becomes active) for NetworkUpgrade::Nu6 instead of Nu7. This implies that the 'Nu6' upgrade will be considered over the 'Nu7' when building transactions.

These changes help in improving transaction sequencing and making sure the related tests are updated to reflect these changes. It further ensures that certain network updates don't interfere with our current system. This contributes to improved system stability and efficiency.

@alexeykoren alexeykoren deleted the nu6-constants branch November 13, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant