Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regtest network #77

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Add Regtest network #77

merged 4 commits into from
Nov 5, 2024

Conversation

alexeykoren
Copy link
Collaborator

@alexeykoren alexeykoren commented Nov 1, 2024

User description

Add Regtest network


PR Type

enhancement


Description

  • Introduced a new RegtestNetwork struct to support the regtest network.
  • Implemented the Parameters trait for RegtestNetwork, defining its network type and activation heights.
  • Added RegtestNetwork to the Network enum and updated the Parameters implementation to handle it.
  • This enhancement allows the system to recognize and operate with the regtest network configuration.

Changes walkthrough 📝

Relevant files
Enhancement
consensus.rs
Add support for Regtest network in consensus module           

components/zcash_protocol/src/consensus.rs

  • Added a new RegtestNetwork struct and implemented the Parameters trait
    for it.
  • Introduced a constant REGTEST_NETWORK for the regtest network.
  • Updated the Network enum to include RegtestNetwork.
  • Modified the Parameters implementation for Network to handle
    RegtestNetwork.
  • +36/-2   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @QED-it QED-it deleted a comment from qodo-merge-pro bot Nov 5, 2024
    Copy link

    @PaulLaux PaulLaux left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    approved with one comment

    }
    }

    #[derive(PartialEq, Eq, Copy, Clone, Debug)]
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    should probably keep hash here and in pub struct RegtestNetwork;

    @QED-it QED-it deleted a comment from qodo-merge-pro bot Nov 5, 2024
    @QED-it QED-it deleted a comment from what-the-diff bot Nov 5, 2024
    @alexeykoren alexeykoren merged commit bb65c05 into zsa1 Nov 5, 2024
    26 checks passed
    @alexeykoren alexeykoren deleted the regtest branch November 5, 2024 15:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants