Update librustzcash to align with orchard crate #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulLaux
reviewed
Jul 16, 2024
Cargo.toml
Outdated
| @@ -58,7 +58,7 @@ sapling = { package = "sapling-crypto", version = "0.1.3" } | |||
|
|
|||
| # - Orchard | |||
| nonempty = "0.7" | |||
| orchard = { version = "0.8.0", default-features = false, git = "https://github.com/QED-it/orchard", branch = "orchardzsa-backward-compatability-0.8.0-ak" } | |||
| orchard = { version = "0.8.0", default-features = false, git = "https://github.com/QED-it/orchard", branch = "orchardzsa-backward-compatability-0.8.0" } | |||
alexeykoren
approved these changes
Jul 16, 2024
alexeykoren
pushed a commit
that referenced
this pull request
Jul 24, 2024
This PR updates `librustzcash` to accommodate the recent refactoring changes in the `orchard` crate. The specific changes include: - Renamed all references from `orchard_flavors` to `orchard_flavor` to match the new module name. - Updated the `OrchardDomain` trait references to `OrchardDomainCommon` to reflect the trait renaming. - Adjusted the `Bundle` structure to use the fixed `NoteValue` type for the `burn` field, replacing the previous generic argument. - Refactored associated code to align with the new structure and naming conventions in the `orchard` crate. - Switched from the `orchardzsa-backward-compatibility-0.8.0-ak` to `orchardzsa-backward-compatibility-0.8.0` branch in `Cargo.toml` to use the latest version of the `orchard` crate. --------- Co-authored-by: Dmitry Demin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
librustzcashto accommodate the recent refactoring changes in theorchardcrate. The specific changes include:orchard_flavorstoorchard_flavorto match the new module name.OrchardDomaintrait references toOrchardDomainCommonto reflect the trait renaming.Bundlestructure to use the fixedNoteValuetype for theburnfield, replacing the previous generic argument.orchardcrate.orchardzsa-backward-compatibility-0.8.0-aktoorchardzsa-backward-compatibility-0.8.0branch inCargo.tomlto use the latest version of theorchardcrate.