Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zsa bundle in v5 vector serialization with burn valid #41

Closed

Conversation

PaulLaux
Copy link

No description provided.

alexeykoren and others added 28 commits June 26, 2023 09:13
- Fix comments.
- Rename `create_test_asset` to `get_burn_tuple` and move it to the end of the file.
- Inline `write_bundle_burn`.
- Remove `test_` prefix for test functions.
…range 1..MAX_MONEY instead of -MAX_MONEY..MAX_MONEY, i.e. not generate negative or zero amount values
@what-the-diff
Copy link

what-the-diff bot commented Sep 12, 2023

PR Summary

  • New 'None' Value Added in Testing
    An additional 'None' value was introduced into the tests module of transparent/demo.rs inside the zcas_export_extensions extension.

  • Modifcation in Issue Bundle Field
    A change in the issue_bundle field was made, introducing a new None value inside the builder.rs located under zcash_primitives.

  • Addition of New Module - 'Issuance'
    We introduced an 'issuance' module in both transaction/components.rs within the zcash_extensions and zcash_primitives.

  • Adjustments to the Range of 'arb_amount'
    In transaction/components/amount.rs, within zcash_primitives, adjustments were made to the range for arb_amount. This is now set to 1..MAX_MONEY.

  • Addition of 'Burn' Related Modules and Files
    We included new modules burn_serialization and burn_validation into transaction/components/orchard.rs, also made changes to read and write burn information in the same file. This was complemented by the addition of files known as burn_serialization.rs and burn_validation.rs under the same directory.

  • File Addition for Housing 'issuance'
    A file named issuance.rs got included under transaction/components/ in zcash_primitives for efficiently managing 'issuance' related controls.

  • Inclusion of Types and Methods
    Added new structures: IssueBundle and Signed in transaction/mod.rs. Moreover, there was an inclusion of a new method TransactionData::issue_bundle within the same file.

  • Additions to 'txid.rs' file
    Added two new methods TxIdDigester::digest_issue along with the implementation of TransactionDigest for IssueDigest type in transaction/txid.rs.

  • Update in Transaction Testing
    For testing purposes, we added a get_burn_tuple function and updated various test vectors in transaction/tests.rs within zcash_primitives.

@PaulLaux PaulLaux closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants