Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue bundle serialization and digest #28

Closed
wants to merge 16 commits into from

Conversation

alexeykoren
Copy link
Collaborator

Issue bundle serialization and digest

@what-the-diff
Copy link

what-the-diff bot commented May 8, 2023

PR Summary

  • Add new field and update serialization functions for Bundle
    Enhances the Bundle struct in zcash_primitives and updates all associated serialization/deserialization functions.
  • Introduce tests, including fuzzing
    Adds tests to ensure the proper functioning of the above mentioned changes, including fuzz testing with proptest.
  • Enhance TransactionData with issuance support
    Adds issuance support to TransactionData for improved transaction management.
  • Update signature hash for v5 transactions
    Improves the signature hash function for version 5 transactions.
  • Add new field to TxDigests struct and implement digest_issue
    Enhances the TxDigests struct with a new field and implements the digest_issue function in the TransactionDigest trait for better commitment digester handling.
  • Update hash functions to include issue commitment
    Enhances hash_transparent_txid, hash_sapling, and hash_orchard functions to include issue commitment for more reliable transaction processing.
  • Correct return type for orchard::commitments functions
    Updates the return type of orchard::commitments::hash*empty functions to Blake2bHash instead of Option for better consistency.

@alexeykoren alexeykoren requested a review from PaulLaux May 15, 2023 10:06
@@ -200,6 +207,7 @@ impl Authorization for TestUnauthorized {
}

#[test]
#[should_panic] // TODO update test vectors
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix TODO or create task

@alexeykoren alexeykoren force-pushed the zsa-bundle-in-v5-vector-serialization branch from e645c15 to d8089d5 Compare July 10, 2023 14:28
@alexeykoren alexeykoren deleted the zsa-bundle-in-v5-vector-serialization branch June 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant