feature / screen size 📱 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninovanhooff
approved these changes
Jan 12, 2024
| } | ||
| portraitDpScreenSize | ||
| } catch (e: Throwable) { | ||
| Q42StatsLogger.e(TAG, "Could not read screen size. Returning null", e) |
There was a problem hiding this comment.
error or warning? Warning seems most appropriate.
| @@ -111,6 +111,8 @@ versions of Android. If unsupported, the corresponding key is omitted. | |||
| | Key | Value | Notes | | |||
| |-|-|-| | |||
| | `screenOrientation`| portrait, landscape, unknown | | |||
| | `screenWidth` | String | Screen width in density-independent pixels. Beware: this value is different when there is a different screen orientation. | | |||
There was a problem hiding this comment.
I think all data types are strings, right? But I might remember incorrectly. As documentation, it would be more informative to list how the backend should parse the string. Reading this table does not answer the question of whether it is an int or float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets screen size in density-independent pixels and portrait mode 📱
Tested on:
✅ Android 13: S22+ / Fold 4
✅ Android 12: S10e
✅ Android 11: emulator
✅ Android 10: device
✅ Android 9: device
✅ Android 8: device
✅ Android 7: emulator
✅ Android 6: emulator
✅ Android 5: emulator