Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inactive task error #312

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Fix/inactive task error #312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768bba1
Fix task cancelled error being raised in inactive player tasks.
EvieePy Jun 24, 2024
445a58e
Remove unnecessary else statement
EvieePy Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions wavelink/player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,13 @@ def __init__(
self._inactivity_wait: int | None = self._node._inactive_player_timeout

def _inactivity_task_callback(self, task: asyncio.Task[bool]) -> None:
result: bool = task.result()
cancelled: bool = task.cancelled()
cancelled: bool = False

try:
result: bool = task.result()
except asyncio.CancelledError:
cancelled = True
result = False

if cancelled or result is False:
logger.debug("Disregarding Inactivity Check Task <%s> as it was previously cancelled.", task.get_name())
Expand Down
Loading