-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Gaussian Gromov wasserstein solvers #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflamary
changed the title
[WIP] gaussian Gromov wasserstein solvers
[MRG] gaussian Gromov wasserstein solvers
Aug 8, 2023
rflamary
changed the title
[MRG] gaussian Gromov wasserstein solvers
[MRG] Gaussian Gromov wasserstein solvers
Aug 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 94.92% 95.62% +0.70%
==========================================
Files 31 65 +34
Lines 6879 13588 +6709
==========================================
+ Hits 6530 12994 +6464
- Misses 349 594 +245 |
cedricvincentcuaz
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rflamary, very nice PR as usual.
I just had few remarks on the documentation.
cedricvincentcuaz
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Updates plots in the linear mappinge xmaple:
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist