Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Gaussian Gromov wasserstein solvers #498

Merged
merged 14 commits into from
Aug 8, 2023
Merged

[MRG] Gaussian Gromov wasserstein solvers #498

merged 14 commits into from
Aug 8, 2023

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Aug 7, 2023

Types of changes

  • Implement Gaussian GW loss
  • Implement Gaussian GW mapping
  • Implement DA mapping between spaces with gaussian Gromov (Closes Linear OT mapping across different spaces #271)
  • Documentation and examples (update linear mapping exmaple)
  • Do all tests

Updates plots in the linear mappinge xmaple:

image

image

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@rflamary rflamary changed the title [WIP] gaussian Gromov wasserstein solvers [MRG] gaussian Gromov wasserstein solvers Aug 8, 2023
@rflamary rflamary changed the title [MRG] gaussian Gromov wasserstein solvers [MRG] Gaussian Gromov wasserstein solvers Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #498 (bde1e19) into master (2bbfbbb) will increase coverage by 0.70%.
Report is 30 commits behind head on master.
The diff coverage is 95.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   94.92%   95.62%   +0.70%     
==========================================
  Files          31       65      +34     
  Lines        6879    13588    +6709     
==========================================
+ Hits         6530    12994    +6464     
- Misses        349      594     +245     

Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rflamary, very nice PR as usual.
I just had few remarks on the documentation.

RELEASES.md Outdated Show resolved Hide resolved
ot/da.py Outdated Show resolved Hide resolved
ot/gaussian.py Outdated Show resolved Hide resolved
@rflamary rflamary merged commit a5cdd5b into master Aug 8, 2023
15 checks passed
@rflamary rflamary deleted the gaussian_gromov branch August 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear OT mapping across different spaces
2 participants