Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links to source code on GitHub from the documentation #1453

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mitya57
Copy link
Collaborator

@mitya57 mitya57 commented Mar 17, 2024

With the current version, if you open e.g. this page, the ‹› links on the right side of the page will point to URLs like https://github.com/Python-Markdown/markdown/tree/3.6//home/runner/work/markdown/markdown/md/markdown/blockprocessors.py which are wrong (note the /home/runner/work/ part).

This commit fixes them by replacing filepath with relative_filepath. It seems to work locally for me, but needs to be tested on our main documentation website.

With the current version, if you open e.g. this page:
https://python-markdown.github.io/reference/markdown/blockprocessors/

The ‹› links on the right side of the page will point to URLs like
https://github.com/Python-Markdown/markdown/tree/3.6//home/runner/work/markdown/markdown/md/markdown/blockprocessors.py

This commit fixes them by replacing `filepath` with `relative_filepath`.
@waylan
Copy link
Member

waylan commented Mar 18, 2024

Thanks for this. I noticed the issue and hadn't yet had the opportunity to track it down.

@waylan waylan added the approved The pull request is ready to be merged. label Mar 18, 2024
@waylan waylan merged commit 993b57b into Python-Markdown:master Mar 18, 2024
16 checks passed
@mitya57 mitya57 deleted the relative-filepath branch March 18, 2024 14:44
@waylan
Copy link
Member

waylan commented Mar 19, 2024

I just did a manual deploy to update the documentation with the current master and this has resolved the issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants