Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonant name validation #339

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Nonant name validation #339

wants to merge 4 commits into from

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Sep 27, 2023 •
edited by DLWoodruff
Loading

TODOs:

  • Make test for bad farmer, both with local and global check
  • See how expensive this check is
  • Produce a better error when the reduction check fails
  • Pickle bundles will fail the test, so it needs to be optional (the default could be True)

bknueven
bknueven commented Nov 2, 2023
View reviewed changes
Copy link
Collaborator Author

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use this module to avoid some unnecessary copying:

https://docs.python.org/3/library/struct.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @DLWoodruff