-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lean on pkgutil.resolve_name for importing apps #446
base: main
Are you sure you want to change the base?
Conversation
With Pylons#445, it no longer makes sense not to use `pkgutil.resolve_name` to handle the importing of WSGI applications in the runner. There is one very minor behavioural change in that `pkgutil.resolve_name` allows a broader syntax for the imports, but supports the same syntax as the existing code being removed, so this is a minor concern. It has the pleasant side effect of removing some legacy code only present for Python 2.6 that was missed when Python 2 support was removed.
Very peculiar. Some of the test workflows randomly hung and had to be rerun. It looks like they failed just as
At first glance, coverage looks like the culprit, but it might just be an innocent bystander. At the very least, there looks to be a race condition somewhere. |
I opened #449 to deal with the issue functional tests hanging. |
With #445, it no longer makes sense not to use
pkgutil.resolve_name
to handle the importing of WSGI applications in the runner. There is one very minor behavioural change in thatpkgutil.resolve_name
allows a broader syntax for the imports, but supports the same syntax as the existing code being removed, so this is a minor concern.It has the pleasant side effect of removing some legacy code only present for Python 2.6 that was missed when Python 2 support was removed.