Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type hinting in code examples #451

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

Yellow-Beans
Copy link
Contributor

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for pycord ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 47b38c7
🔍 Latest deploy log https://app.netlify.com/sites/pycord/deploys/66242bd4f2610f0008f4f94c
😎 Deploy Preview https://deploy-preview-451--pycord.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the related explanations to explain the type-hinting then?

Copy link
Contributor Author

@Yellow-Beans Yellow-Beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added text, explaining the type hint

@Lulalaby Lulalaby requested a review from Dorukyum April 20, 2024 21:28
@Lulalaby Lulalaby merged commit 39a721d into Pycord-Development:main Apr 20, 2024
25 checks passed
Lulalaby added a commit that referenced this pull request Apr 20, 2024
Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Yellow-Beans <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
Lulalaby added a commit that referenced this pull request Apr 21, 2024
* added type hinting in code examples (#451)


Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Dorukyum <[email protected]>

* fix: remove community resources which are not open-source

Signed-off-by: Lala Sabathil <[email protected]>

---------

Signed-off-by: Lala Sabathil <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Yellow-Beans <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
Lulalaby added a commit that referenced this pull request Jun 5, 2024
* added type hinting in code examples (#451)


Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Dorukyum <[email protected]>

* fix: remove community resources which are not open-source

Signed-off-by: Lala Sabathil <[email protected]>

* Delete .github/dependabot.yml (#464)

Signed-off-by: Lala Sabathil <[email protected]>

* chore(deps): Bump peaceiris/actions-gh-pages from 3 to 4 (#457)

Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](peaceiris/actions-gh-pages@v3...v4)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump github/codeql-action from 2 to 3 (#456)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump actions/setup-python from 4 to 5 (#455)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(metadata): change embed icon to match main website (#465)

* feat(metadata): change Discord embed icon `image` to `thumbnail`

* fix: image sizing

* fix: metadata type

* docs: remove `#ext-pages` channel (#466)

Signed-off-by: JustaSqu1d <[email protected]>

* docs: add more information about application commands (#467)

* docs: add option decorator

* docs: slash command groups in cogs

* docs: minor grammar fix

* fix: spelling mistake

---------

Signed-off-by: Lala Sabathil <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: JustaSqu1d <[email protected]>
Co-authored-by: Yellow-Beans <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants