Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that at some point SkillCorner changed all their "time" keys to "timestamp", not only in the "jsonl" files.
So, I rewrote
__load_json()
and added__load_json_raw()
the latter renames any "timestamp" key back to "time" to make it compatible with every time the "time" key is required in the deserializer.Also added a test and a test file for the "timestamp" situation. This test simply loads the dataset, the rest should be the same as the other tests.
Note: I removed a lot of 2nd half frames from the test file, because the file size was greater than 50MB.