Add InterceptionEvent #230
Conversation
| @@ -761,6 +792,14 @@ def deserialize(self, inputs: OptaInputs) -> EventDataset: | |||
| **duel_event_kwargs, | |||
| **generic_event_kwargs, | |||
| ) | |||
| elif type_id == EVENT_TYPE_INTERCEPTION: | |||
There was a problem hiding this comment.
Opta also has a "blocked pass" event. Would it make sense to parse it as an interception too?
blocked pass := When a player tries to cut out an opposition pass by any means. Similar to an interception except there is much less reading of the pass.
| @@ -477,6 +510,24 @@ def deserialize(self, inputs: WyscoutInputs) -> EventDataset: | |||
| **generic_event_args, | |||
| ) | |||
|
|
|||
| # If also an interception event, add this before other event (It is a tag on multiple wyscout_events) | |||
There was a problem hiding this comment.
Wyscout does not have a separate event type for interceptions. Instead, interceptions are recorded as a pass, duel or touch event with an "interception" tag. Your current implementation works well for passes, but for consistency with other providers (and socceraction) I would convert these duels/touch events to an interception. Not to an interception + duel.
…el as interception.
|
Addition:
|
|
@MKlaasman thanks for your work. Can you please merge master in? There are some small merge conflicts due to changes from Pieters PRs. |
# Conflicts: # kloppy/infra/serializers/event/statsbomb/deserializer.py # kloppy/tests/test_helpers.py # kloppy/tests/test_state_builder.py # kloppy/tests/test_statsbomb.py # kloppy/tests/test_to_records.py
fixes #222
Notes:
What do you think? @probberechts @JanVanHaaren