Fix sportec current #217
Merged
Fix sportec current #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenvo
commented
Sep 7, 2023
| @@ -584,6 +572,13 @@ def deserialize(self, inputs: SportecEventDataInputs) -> EventDataset: | |||
|
|
|||
| events.append(transformer.transform_event(event)) | |||
|
|
|||
| for i, event in enumerate(events[:-1]): | |||
There was a problem hiding this comment.
Should use X-Source-Position/Y-Source-Position here.
koenvo
commented
Sep 7, 2023
kloppy/tests/test_sportec.py
Outdated
| ) | ||
|
|
||
| first_pass = dataset.find("pass") | ||
| assert first_pass.receiver_coordinates == first_pass.next().coordinates |
There was a problem hiding this comment.
Should use X-Source-Position/Y-Source-Position here.
|
@UnravelSports can you check this one? |
JanVanHaaren
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #216
OwnGoalresultX/Y-Source-Positionasreceiver_coordinateswhen possibleCloses #216