Missing 'qualifiers' key in event_factory kwargs

[UnravelSports]

Hi,

I was trying to load some Opta data and got the following error:

TypeError: TakeOnEvent.__init__() missing 1 required positional argument: 'qualifiers'

I checked and it seemed to only occur at TakeOnEvents (for this particular game of data I was testing).

I simply added these two lines to add a qualifiers key to kwargs if it doesn't exist.

 if 'qualifiers' not in kwargs:
        kwargs['qualifiers'] = None

It seems consistent with the lines above in the create_event function where we add "freeze_frame" and/or "related_event_ids" if they don't exist. Like so:

def create_event(event_cls: Type[T], **kwargs) -> T:
    """
    Do the actual construction of an event.

    This method does a couple of things:
    1. Fill in some arguments when not passed
    2. Pass only arguments that are accepted by the `event_cls`.
       This is required in cases an EventFactory initialized less rich
       Events than data is passed for. E.g. `expected_goal` is passed
       to a regular `ShotEvent`.
       Normally this would break because of an 'Unexpected argument' exception,
       but we filter those arguments out.
    """
    extra_kwargs = {"state": {}}
    if "related_event_ids" not in kwargs:
        extra_kwargs["related_event_ids"] = []

    if "freeze_frame" not in kwargs:
        kwargs["freeze_frame"] = None

   etc. etc.

[koenvo]

@UnravelSports can you add TakeOn event to the Opta test to make sure it works with real data?

[koenvo]

I'm trying to figure out why/where this breaks and I can't seem to find it. The build_take_on call from the Opta deserializer does include qualifiers

[JanVanHaaren]

I'm trying to figure out why/where this breaks and I can't seem to find it. The build_take_on call from the Opta deserializer does include qualifiers

I suspect the positional argument qualifiers should be provided before the keyword arguments.

kloppy/kloppy/infra/serializers/event/opta/deserializer.py

Line 745 in e29808c

qualifiers=None,

event = self.event_factory.build_take_on(
	**take_on_event_kwargs,
	**generic_event_kwargs,
	qualifiers=None,
)

event = self.event_factory.build_take_on(
	qualifiers=None,
	**take_on_event_kwargs,
	**generic_event_kwargs,
)

[koenvo]

I'm trying to figure out why/where this breaks and I can't seem to find it. The build_take_on call from the Opta deserializer does include qualifiers

I suspect the positional argument qualifiers should be provided before the keyword arguments.

kloppy/kloppy/infra/serializers/event/opta/deserializer.py

Line 745 in e29808c

qualifiers=None,

event = self.event_factory.build_take_on(
	**take_on_event_kwargs,
	**generic_event_kwargs,
	qualifiers=None,
)

event = self.event_factory.build_take_on(
	qualifiers=None,
	**take_on_event_kwargs,
	**generic_event_kwargs,
)

Noticed the same. But can't understand why this could make a difference. I believe in both cases they are all keyword arguments.

>>> a = {}
>>> b = {}
>>> c = dict(*a, *b, piet=1)
>>> c
{'piet': 1}
>>> d = dict(piet=1, *a, *b)
>>> d
{'piet': 1}

[JanVanHaaren]

@koenvo I believe this pull request is no longer relevant. While this issue indeed occurs in the most recent release, it appears to have been addressed already in the master branch.