Feature/sportec tracking #208
Conversation
…e method. This way the metadata parsing for Sportec can be shared between the event- and trackingdata Deserializers
…ossible and only convert string attributes to float when constructing a Frame. When only_alive or sample_rate are set this will prevent lots of unnecessary type convertions
|
|
||
| assert player_data.coordinates == Point(x=0.35, y=-25.26) | ||
|
|
||
| # We don't load distance right now as it doesn't |
There was a problem hiding this comment.
There is also an Acceleration attribute in the Sportec data, is there a possibility to add this to the dataset?
There was a problem hiding this comment.
Jup. Would like to implement this in a different ticket to first check other providers too.
|
|
||
| def _sportec_metadata_from_xml_elm(match_root) -> SportecMetadata: | ||
| """ | ||
| Load metadata from Sportec XML element. This part is shared between event- and tracking data. |
| if player_id != "ball" | ||
| }, | ||
| other_data={}, | ||
| ball_coordinates=Point3D( |
…vent vs tracking data. Therefore, Provider alone cannot be used to identify a CoordinateSystem. Use DatasetType to determine correct CoordinateSystem. Also refactor construction of DatasetTransformer into DatasetTransformerBuilder, and use it from both TrackingDataDeserializer as EventDataDeserializer.
|
I've ran it and it seems to be working correctly after you added ball speed and the updated coordinate systems! |
| dataset_type: DatasetType, | ||
| ): | ||
| from_coordinate_system = build_coordinate_system( | ||
| provider, length=length, width=width, dataset_type=dataset_type |
There was a problem hiding this comment.
Perhaps use the same formatting as for the to_coordinate_system? The similarties and differences between the two calls to build_coordinate_system would become more apparent.
| periods = [ | ||
| Period( | ||
| id=1, | ||
| start_timestamp=10_000 / SPORTEC_FPS, |
There was a problem hiding this comment.
It is not immediately clear to me where the 10_000, 100_000, 200_000 and 250_000 constant values come from. I suspect it is a Sportec convention. How about moving these constant values to a variable with a more descriptive name? Or adding a quick comment explaining the convention?
…ormatting improvement
sportec.loadand addedsportec.load_event