minor fixes

PySport · Aug 8, 2024 · 7b8afba · 7b8afba
1 parent 7f63b7e
commit 7b8afba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/kloppy/infra/serializers/event/sportec/deserializer.py b/kloppy/infra/serializers/event/sportec/deserializer.py
@@ -75,10 +75,8 @@ def _team_from_xml_elm(team_elm) -> Team:
             first_name=player_elm.attrib["FirstName"],
             last_name=player_elm.attrib["LastName"],
             starting_position=position_types_mapping.get(
-                player_elm.attrib["PlayingPosition"], PositionType.Unknown
-            )
-            if "PlayingPosition" in player_elm.attrib
-            else PositionType.Unknown,
+                player_elm.attrib.get("PlayingPosition"), PositionType.Unknown
+            ),
             starting=player_elm.attrib["Starting"] == "true",
         )
         for player_elm in team_elm.Players.iterchildren("Player")

diff --git a/kloppy/tests/test_datafactory.py b/kloppy/tests/test_datafactory.py
@@ -43,7 +43,7 @@ def test_correct_deserialization(self, event_data: str):
         assert player.player_id == "38804"
         assert player.jersey_no == 1
         assert str(player) == "Daniel Bold"
-        assert player.starting_position == PositionType.Unknown
+        assert player.starting_position == None
         assert player.starting
 
         assert dataset.metadata.periods[0].id == 1

diff --git a/kloppy/tests/test_opta.py b/kloppy/tests/test_opta.py
@@ -111,7 +111,7 @@ def test_player_position(self, dataset):
 
         # Substituted players don't have a position
         sub_player = dataset.metadata.teams[0].get_player_by_id("88022")
-        assert sub_player.starting_position is None
+        assert sub_player.starting_position is PositionType.Unknown
         assert not sub_player.starting
 
     def test_periods(self, dataset):